Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to speak next and previous lines/paragraphs when navigati… #17256

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nvdaes
Copy link
Sponsor Contributor

@nvdaes nvdaes commented Oct 7, 2024

…ng with braille

Link to issue number:

Fixes #17053

Summary of the issue:

Sometimes, it may be desirable tohear lines when navigating with braille.

Description of user facing changes

  • A new command, not assigned to gestures, is available in the braille category to toggle speaking of lines/paragraphs when navigating with braille, to enable or disable this feature. A new checkbox for this has been added in the braille settings panel as well.

Description of development approach

  • A new key for this feature has been added to configSpec.py. The value is a boolean (False by default).
  • A new script has been added to globalCommands.py.
  • A new function has been added to braille.py, to be used by next and previousLine functions, also modified so that info is expanded to the corresponding read unit, i.e., line or paragraph.
  • The braille settings panel has a new checkbox to toggle this feature.

Testing strategy:

Tested manually in Notepad and Window console, with braille following caret, review cursor and automatic modes.
Also, checked that indentation is reported when reading by lines, not by paragraphs, as expected when unit is specified for speakTextInfo function.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nvdaes nvdaes requested a review from a team as a code owner October 7, 2024 05:19
@nvdaes nvdaes marked this pull request as draft October 7, 2024 05:19
@burmancomp
Copy link
Contributor

Fine.

What do you think about setting in braille category?

@nvdaes
Copy link
Sponsor Contributor Author

nvdaes commented Oct 7, 2024

@burmancomp , feel free to test this again. I've added cancelSpeech() before speaking line or paragraph, and a checkbox in the braille settings panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

braille: optionally speak line when moving from line to line
2 participants